Skip to content

[STACKED on #883] fix(util): write TPM quotes atomically - #961

Merged
kvinwang merged 1 commit into
masterfrom
codex/fix-util-atomic-tpm-quotes
Aug 5, 2026
Merged

[STACKED on #883] fix(util): write TPM quotes atomically#961
kvinwang merged 1 commit into
masterfrom
codex/fix-util-atomic-tpm-quotes

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

STACKED PR — merge #883 first.

Problem

TPM quote output was overwritten in place. A concurrent reader or interrupted write could consume a truncated quote and report an attestation parse/signature failure.

Root cause and fix

Write the complete quote to a temporary file and atomically rename it to the requested output.

Implementation

The branch records the following focused implementation work:

  • fix(util): write TPM quotes atomically

Changed paths:

  • dstack/dstack-util/src/main.rs

Scope

This PR addresses one logical util finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

Verification

  • git diff --check origin/codex/fix-guest-atomic-credentials..origin/codex/fix-util-atomic-tpm-quotes: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/fix-guest-atomic-credentials branch from cfba158 to 83076e6 Compare August 4, 2026 07:49
@kvinwang
kvinwang force-pushed the codex/fix-util-atomic-tpm-quotes branch from 2aac350 to 456eea6 Compare August 5, 2026 15:59
@kvinwang
kvinwang changed the base branch from codex/fix-guest-atomic-credentials to master August 5, 2026 16:06
@kvinwang
kvinwang enabled auto-merge August 5, 2026 16:06
@kvinwang
kvinwang disabled auto-merge August 5, 2026 16:07
@kvinwang
kvinwang merged commit e995dae into master Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants